Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: partition HidDelegate observers by browser context #40215

Merged
merged 1 commit into from
Oct 17, 2023
Merged

refactor: partition HidDelegate observers by browser context #40215

merged 1 commit into from
Oct 17, 2023

Conversation

codebytere
Copy link
Member

Description of Change

Refs CL:3764713

ElectronHidDelegate should maintain separate ScopedObservations for each BrowserContext instead of using the same observations for its observers.

See Impetus Bug: 1349514

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 16, 2023
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/27-x-y PR should also be added to the "27-x-y" branch. target/28-x-y PR should also be added to the "28-x-y" branch. and removed new-pr 🌱 PR opened in the last 24 hours labels Oct 16, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 16, 2023
deepak1556
deepak1556 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like similar changes are also needed for serial delegate.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Oct 17, 2023
@jkleinsc jkleinsc merged commit 73a42d0 into main Oct 17, 2023
22 checks passed
@jkleinsc jkleinsc deleted the partition-hiddelegate-observers branch October 17, 2023 20:54
@release-clerk
Copy link

release-clerk bot commented Oct 17, 2023

No Release Notes

@trop trop bot mentioned this pull request Oct 17, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 17, 2023

I have automatically backported this PR to "27-x-y", please check out #40237

@trop trop bot added in-flight/27-x-y and removed target/27-x-y PR should also be added to the "27-x-y" branch. labels Oct 17, 2023
@trop trop bot mentioned this pull request Oct 17, 2023
Merged
@trop
Copy link
Contributor

trop bot commented Oct 17, 2023

I have automatically backported this PR to "28-x-y", please check out #40238

@trop trop bot added in-flight/28-x-y merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. and removed target/28-x-y PR should also be added to the "28-x-y" branch. in-flight/27-x-y in-flight/28-x-y labels Oct 17, 2023
felixrieseberg pushed a commit to felixrieseberg/electron that referenced this pull request Oct 25, 2023
@codebytere @felixrieseberg
refactor: partition HidDelegate observers by browser context (electro…
732fe95 
…n#40215)
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@codebytere
refactor: partition HidDelegate observers by browser context (electro…
ce9d30a 
…n#40215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
merged/27-x-y PR was merged to the "27-x-y" branch. merged/28-x-y PR was merged to the "28-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @jkleinsc @zcbenz @deepak1556